Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-04-16 Thread Samuel Thibault
Well, to be honest, I don't think I'll have the time to dive into grub-probe to see where the breakage comes from etc. so as far as I'm concerned, I'll just archive the discussion. If people really want to see the Hurd work for them, they'll have to do a bit of the work. People can't just rely on

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-26 Thread Daniel Kiper
On Thu, Mar 22, 2018 at 08:14:50PM +0100, Samuel Thibault wrote: > Daniel Kiper, on jeu. 22 mars 2018 15:16:46 +0100, wrote: > > On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > > > @@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)' > > > --class hurd --cla

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-22 Thread Samuel Thibault
Daniel Kiper, on jeu. 22 mars 2018 15:16:46 +0100, wrote: > On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > > @@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)' > > --class hurd --class gnu - > > EOF > >save_default_entry | grub_add_tab > >

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-22 Thread Daniel Kiper
On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > grub-probe --device /dev/sda --target=drive > > would currently print on Linux x86 "hostdisk//dev/sda,msdos1", i.e. not I have a feeling that grub-probe should be fixed instead of that. Probably it was broken at some point because

[PATCHv2] os-prober: Fix translating device to mach format

2018-03-14 Thread Samuel Thibault
grub-probe --device /dev/sda --target=drive would currently print on Linux x86 "hostdisk//dev/sda,msdos1", i.e. not something we can translate easily. We can instead use compatibility_hint which have more well-defined format (hd0,1) Signed-off-by: Samuel Thibault --- new in v2: Fix typo and b