Re: [PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-15 Thread Glenn Washburn
On Sat, 12 Dec 2020 16:19:18 +0100 Daniel Kiper wrote: > On Fri, Dec 11, 2020 at 07:10:18PM -0600, Glenn Washburn wrote: > > On Thu, 10 Dec 2020 17:07:07 +0100 > > Daniel Kiper wrote: > > > > > On Tue, Dec 08, 2020 at 04:45:45PM -0600, Glenn Washburn wrote: > > > > First, check to make sure that

Re: [PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-12 Thread Daniel Kiper
On Fri, Dec 11, 2020 at 07:10:18PM -0600, Glenn Washburn wrote: > On Thu, 10 Dec 2020 17:07:07 +0100 > Daniel Kiper wrote: > > > On Tue, Dec 08, 2020 at 04:45:45PM -0600, Glenn Washburn wrote: > > > First, check to make sure that source disk has a known size. If > > > not, print debug message and

Re: [PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-11 Thread Glenn Washburn
On Thu, 10 Dec 2020 17:07:07 +0100 Daniel Kiper wrote: > On Tue, Dec 08, 2020 at 04:45:45PM -0600, Glenn Washburn wrote: > > First, check to make sure that source disk has a known size. If > > not, print debug message and return error. There are 4 cases where > > GRUB_DISK_SIZE_UNKNOWN is set (bi

Re: [PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:45PM -0600, Glenn Washburn wrote: > First, check to make sure that source disk has a known size. If not, print > debug message and return error. There are 4 cases where > GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in > all those cases proc

[PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-08 Thread Glenn Washburn
First, check to make sure that source disk has a known size. If not, print debug message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing continues. So this is probably a bit conservative. However, 3 of