Re: [PATCH v8 08/22] protectors: Add key protectors framework

2024-01-19 Thread Gary Lin via Grub-devel
On Thu, Jan 18, 2024 at 03:02:19PM +0800, Gary Lin wrote: > On Wed, Jan 17, 2024 at 05:58:25AM +0300, Vladimir 'phcoder' Serbinenko wrote: > > Any strong reason to have it in kernel? It doesn't seem to be > > necessary in non-crypto cases. Separate module or cryptodisk looks > > like better places

Re: [PATCH v8 08/22] protectors: Add key protectors framework

2024-01-17 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 05:58:25AM +0300, Vladimir 'phcoder' Serbinenko wrote: > Any strong reason to have it in kernel? It doesn't seem to be > necessary in non-crypto cases. Separate module or cryptodisk looks > like better places > I have no strong opinion about the location as long as it works

Re: [PATCH v8 08/22] protectors: Add key protectors framework

2024-01-16 Thread Vladimir 'phcoder' Serbinenko
Any strong reason to have it in kernel? It doesn't seem to be necessary in non-crypto cases. Separate module or cryptodisk looks like better places On Tue, Jan 16, 2024 at 12:22 PM Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > A key protector encapsulates functionality to retrieve an

[PATCH v8 08/22] protectors: Add key protectors framework

2024-01-16 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma