Re: [PATCH v8 03/22] libtasn1: disable code not needed in grub

2024-01-18 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 04:15:47PM +0800, Gary Lin wrote: > On Wed, Jan 17, 2024 at 05:28:20AM +0300, Vladimir 'phcoder' Serbinenko wrote: > > I would suggest something a bit more descriptive than if 0. What about > > #ifdef GRUB_SKIPPED_IMPORTING ? > > > That makes sense and improves the readabil

Re: [PATCH v8 03/22] libtasn1: disable code not needed in grub

2024-01-17 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 05:28:20AM +0300, Vladimir 'phcoder' Serbinenko wrote: > I would suggest something a bit more descriptive than if 0. What about > #ifdef GRUB_SKIPPED_IMPORTING ? > That makes sense and improves the readability. Will update it for v9. Thanks, Gary Lin > Le mar. 16 janv. 2

Re: [PATCH v8 03/22] libtasn1: disable code not needed in grub

2024-01-16 Thread Vladimir 'phcoder' Serbinenko
I would suggest something a bit more descriptive than if 0. What about #ifdef GRUB_SKIPPED_IMPORTING ? Le mar. 16 janv. 2024, 12:24, Gary Lin via Grub-devel a écrit : > From: Daniel Axtens > > We don't expect to be able to write ASN.1, only read it, > so we can disable some code. > > Do that wi

[PATCH v8 03/22] libtasn1: disable code not needed in grub

2024-01-16 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex