Re: [PATCH v7 12/17] luks2: Better error handling when setting up the cryptodisk

2020-12-07 Thread Patrick Steinhardt
On Mon, Dec 07, 2020 at 10:04:01PM -0600, Glenn Washburn wrote: > On Sun, 6 Dec 2020 20:35:13 +0100 > Patrick Steinhardt wrote: > > > On Fri, Dec 04, 2020 at 10:43:41AM -0600, Glenn Washburn wrote: > > > First, check to make sure that source disk has a known size. If > > > not, print debug messag

Re: [PATCH v7 12/17] luks2: Better error handling when setting up the cryptodisk

2020-12-07 Thread Glenn Washburn
This patch got mangled accidentally with patch 5. I'll update them both. Glenn On Fri, 4 Dec 2020 10:43:41 -0600 Glenn Washburn wrote: > First, check to make sure that source disk has a known size. If not, > print debug message and return error. There are 4 cases where > GRUB_DISK_SIZE_UNKNOW

Re: [PATCH v7 12/17] luks2: Better error handling when setting up the cryptodisk

2020-12-07 Thread Glenn Washburn
On Sun, 6 Dec 2020 20:35:13 +0100 Patrick Steinhardt wrote: > On Fri, Dec 04, 2020 at 10:43:41AM -0600, Glenn Washburn wrote: > > First, check to make sure that source disk has a known size. If > > not, print debug message and return error. There are 4 cases where > > GRUB_DISK_SIZE_UNKNOWN is se

Re: [PATCH v7 12/17] luks2: Better error handling when setting up the cryptodisk

2020-12-06 Thread Patrick Steinhardt
On Fri, Dec 04, 2020 at 10:43:41AM -0600, Glenn Washburn wrote: > First, check to make sure that source disk has a known size. If not, print > debug message and return error. There are 4 cases where > GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in > all those cases proc

[PATCH v7 12/17] luks2: Better error handling when setting up the cryptodisk

2020-12-04 Thread Glenn Washburn
First, check to make sure that source disk has a known size. If not, print debug message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing continues. So this is probably a bit conservative. However, 3 of