Re: [PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments

2020-12-07 Thread Daniel Kiper
On Fri, Dec 04, 2020 at 10:43:31AM -0600, Glenn Washburn wrote: > This ensures that expected order of operations is preserved when arguments > are expressions. > > Signed-off-by: Glenn Washburn Good catch! Reviewed-by: Daniel Kiper Daniel ___ Grub-de

Re: [PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments

2020-12-06 Thread Patrick Steinhardt
On Fri, Dec 04, 2020 at 10:43:31AM -0600, Glenn Washburn wrote: > This ensures that expected order of operations is preserved when arguments > are expressions. > > Signed-off-by: Glenn Washburn Reviewed-by: Patrick Steinhardt > --- > include/grub/misc.h | 4 ++-- > 1 file changed, 2 insertion

[PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments

2020-12-04 Thread Glenn Washburn
This ensures that expected order of operations is preserved when arguments are expressions. Signed-off-by: Glenn Washburn --- include/grub/misc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/grub/misc.h b/include/grub/misc.h index b7ca6dd58..780a34e90 100644 --