Re: [PATCH v6 07/12] luks2: Better error handling when setting up the cryptodisk

2020-12-04 Thread Glenn Washburn
On Fri, 4 Dec 2020 14:19:29 +0100 Daniel Kiper wrote: > On Thu, Dec 03, 2020 at 10:24:46AM -0600, Glenn Washburn wrote: > > On Thu, 3 Dec 2020 14:31:49 +0100 > > Daniel Kiper wrote: > > > > > On Fri, Nov 27, 2020 at 03:03:39AM -0600, Glenn Washburn wrote: > > > > First, check to make sure that s

Re: [PATCH v6 07/12] luks2: Better error handling when setting up the cryptodisk

2020-12-04 Thread Daniel Kiper
On Thu, Dec 03, 2020 at 10:24:46AM -0600, Glenn Washburn wrote: > On Thu, 3 Dec 2020 14:31:49 +0100 > Daniel Kiper wrote: > > > On Fri, Nov 27, 2020 at 03:03:39AM -0600, Glenn Washburn wrote: > > > First, check to make sure that source disk has a known size. If > > > not, print debug message and r

Re: [PATCH v6 07/12] luks2: Better error handling when setting up the cryptodisk

2020-12-03 Thread Glenn Washburn
On Thu, 3 Dec 2020 14:31:49 +0100 Daniel Kiper wrote: > On Fri, Nov 27, 2020 at 03:03:39AM -0600, Glenn Washburn wrote: > > First, check to make sure that source disk has a known size. If > > not, print debug message and return error. There are 4 cases where > > GRUB_DISK_SIZE_UNKNOWN is set (bio

Re: [PATCH v6 07/12] luks2: Better error handling when setting up the cryptodisk

2020-12-03 Thread Daniel Kiper
On Fri, Nov 27, 2020 at 03:03:39AM -0600, Glenn Washburn wrote: > First, check to make sure that source disk has a known size. If not, print > debug message and return error. There are 4 cases where > GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in > all those cases proc

[PATCH v6 07/12] luks2: Better error handling when setting up the cryptodisk

2020-11-27 Thread Glenn Washburn
First, check to make sure that source disk has a known size. If not, print debug message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing continues. So this is probably a bit conservative. However, 3 of