Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 03:28:37PM +0100, Javier Martinez Canillas wrote: > On 11/29/19 4:46 PM, Daniel Kiper wrote: > > On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: > >> On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > >>> We had a discussion with Daniel and

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-12-13 Thread Javier Martinez Canillas
On 11/29/19 4:46 PM, Daniel Kiper wrote: > On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: >> On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: >>> We had a discussion with Daniel and agreed on following: >>> 1) we accept the feature >> >> Great, thanks. >> >>> 2)

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-11-29 Thread Daniel Kiper
On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: > On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > > We had a discussion with Daniel and agreed on following: > > 1) we accept the feature > > Great, thanks. > > > 2) we want to have an option to specify grub confi

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Javier Martinez Canillas
On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > We had a discussion with Daniel and agreed on following: > 1) we accept the feature Great, thanks. > 2) we want to have an option to specify grub config file. And if this > option is present, the scanning would be disabled Sure, you men

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Vladimir 'phcoder' Serbinenko
We had a discussion with Daniel and agreed on following: 1) we accept the feature 2) we want to have an option to specify grub config file. And if this option is present, the scanning would be disabled 3) to avoid multiple round-trips can we request all the possible files in parallel? On Wed, 30 O

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Javier Martinez Canillas
Hello Vladimir, On 10/29/19 5:18 PM, Vladimir 'phcoder' Serbinenko wrote: > What is the problem with main grub.cfg just including the files based on > environment variables? > Do you mean having a grub.cfg that fetches the machine specific grub.cfg? i.e: configfile (tftp,$net_default_server)/EFI

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-29 Thread Vladimir 'phcoder' Serbinenko
What is the problem with main grub.cfg just including the files based on environment variables? On Tue, 29 Oct 2019, 15:16 Javier Martinez Canillas, wrote: > From: Paulo Flabiano Smorigo > > This patch implements a search for a specific configuration when the config > file is on a remoteserver.

[PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-29 Thread Javier Martinez Canillas
From: Paulo Flabiano Smorigo This patch implements a search for a specific configuration when the config file is on a remoteserver. It uses the following order: 1) DHCP client UUID option. 2) MAC address (in lower case hexadecimal with dash separators); 3) IP (in upper case hexadecimal)