Re: Minimum compiler version (was: Re: [PATCH v5 0/4] Update gnulib and drop some patches)

2022-03-04 Thread Daniel Kiper
On Mon, Feb 28, 2022 at 12:24:50PM -0500, Robbie Harwood wrote: > Glenn Washburn writes: > > > GCC 5.1.0 looks like it came out on April 22, 2015[1] and 5.2 was used > > in Ubuntu Xenial from 2016 (which is no longer supported). At what > > point do we bump up the minimum supported version? And do

Re: Minimum compiler version (was: Re: [PATCH v5 0/4] Update gnulib and drop some patches)

2022-02-28 Thread Robbie Harwood
Glenn Washburn writes: > GCC 5.1.0 looks like it came out on April 22, 2015[1] and 5.2 was used > in Ubuntu Xenial from 2016 (which is no longer supported). At what > point do we bump up the minimum supported version? And doing so > wouldn't mean that GRUB can't be compiled with eariler versions

Re: Minimum compiler version (was: Re: [PATCH v5 0/4] Update gnulib and drop some patches)

2022-02-25 Thread Heinrich Schuchardt
On 2/26/22 02:50, Glenn Washburn wrote: On Tue, 22 Feb 2022 18:17:51 +0100 Daniel Kiper wrote: The GRUB INSTALL file says: The Requirements GRUB depends on some software packages installed into your system. If you don't have any of them, please obtain and install

Minimum compiler version (was: Re: [PATCH v5 0/4] Update gnulib and drop some patches)

2022-02-25 Thread Glenn Washburn
On Tue, 22 Feb 2022 18:17:51 +0100 Daniel Kiper wrote: > The GRUB INSTALL file says: > > The Requirements > > > GRUB depends on some software packages installed into your system. If > you don't have any of them, please obtain and install them before > configuring the G

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-24 Thread Robbie Harwood
Daniel Kiper writes: > Robbie Harwood wrote: > >> Also, gnulib's position on sign comparison issues is to ignore them, >> so the "fix" from our end would probably be to pragma them > > Huh! Where did you see that? Could you point me a source where they > say that thing? "If -Wsign-compare compla

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-24 Thread Daniel Kiper
On Tue, Feb 22, 2022 at 12:35:00PM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > > Robbie Harwood wrote: > > > >> I don't get that, actually. What OS/gcc? It's fine with the gcc-11 > >> I'm using here. > > > > Does gcc-11 work with the configure mentioned above? > > > > Anyway, Debian

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-22 Thread Robbie Harwood
Daniel Kiper writes: > Robbie Harwood wrote: > >> I don't get that, actually. What OS/gcc? It's fine with the gcc-11 >> I'm using here. > > Does gcc-11 work with the configure mentioned above? > > Anyway, Debian 9, arm-linux-gnueabihf-gcc (Debian 6.3.0-18) 6.3.0 20170516. Yes, with arm-linux-g

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-22 Thread Daniel Kiper
On Tue, Feb 22, 2022 at 11:44:37AM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > > On Wed, Feb 16, 2022 at 04:41:38PM -0500, Robbie Harwood wrote: > >> Changes in this version: > >> > >> - Include most _GL_* defines from gnulib. Hopefully we do not need all > >> their > >> prereq log

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-22 Thread Robbie Harwood
Daniel Kiper writes: > On Wed, Feb 16, 2022 at 04:41:38PM -0500, Robbie Harwood wrote: >> Changes in this version: >> >> - Include most _GL_* defines from gnulib. Hopefully we do not need all their >> prereq logic as well, but I don't know what the compilers we support are, >> so >> please

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-22 Thread Daniel Kiper
On Wed, Feb 16, 2022 at 04:41:38PM -0500, Robbie Harwood wrote: > Changes in this version: > > - Include most _GL_* defines from gnulib. Hopefully we do not need all their > prereq logic as well, but I don't know what the compilers we support are, so > please correct that if needed. > > - Avoi

Re: [PATCH v5 0/4] Update gnulib and drop some patches

2022-02-18 Thread Glenn Washburn
On Wed, 16 Feb 2022 16:41:38 -0500 Robbie Harwood wrote: > Changes in this version: > > - Include most _GL_* defines from gnulib. Hopefully we do not need all their > prereq logic as well, but I don't know what the compilers we support are, so > please correct that if needed. > > - Avoid c

[PATCH v5 0/4] Update gnulib and drop some patches

2022-02-16 Thread Robbie Harwood
Changes in this version: - Include most _GL_* defines from gnulib. Hopefully we do not need all their prereq logic as well, but I don't know what the compilers we support are, so please correct that if needed. - Avoid creating empty #defines. - Fix issues with building gnulib's allocation m