Hi Alec,
I believe you're are right. Making "do while" a "while" will not make
any difference for the infinite scenario.
Adding a check which you mentioned "checking a value after removing the
excess" will resolve the concerns I raised.
Thank you!
Regards,
Avnish Chouhan
Reviewed-by: Avnish
On Wed, May 21, 2025 at 12:51:24PM +, Alec Brown wrote:
> From: Peter Jones
>
> The BootLoaderSpec (BLS) defines a scheme where different bootloaders can
> share a format for boot items and a configuration directory that accepts
> these common configurations as drop-in files.
>
> The BLS Speci
On Thu, June 5, 2025 at 2:02 AM, Avnish Chouhan wrote:
> On 2025-06-04 01:17, Alec Brown wrote:
> > On Thu, May 29, 2025 at 6:59 AM, Avnish Chouhan
> > wrote:
> >> On 2025-05-21 18:21, grub-devel-requ...@gnu.org wrote:
> [...]
> >> > + while (*separator == ' ' || *separator == '\t');
> >>
>
On 2025-06-04 01:17, Alec Brown wrote:
On Thu, May 29, 2025 at 6:59 AM, Avnish Chouhan
wrote:
On 2025-05-21 18:21, grub-devel-requ...@gnu.org wrote:
[...]
> + while (*separator == ' ' || *separator == '\t');
What's the use of this while condition? It may result in an infinite
loop...
On Thu, May 29, 2025 at 6:59 AM, Avnish Chouhan wrote:
> On 2025-05-21 18:21, grub-devel-requ...@gnu.org wrote:
[...]
> > +static grub_err_t
> > +blsuki_add_keyval (grub_blsuki_entry_t *entry, char *key, char *val)
> > +{
> > + char *k, *v;
> > + struct keyval **kvs, *kv;
> > + grub_size_t si
, daniel.ki...@oracle.com,
jan.setjeeil...@oracle.com, alec.r.br...@oracle.com,
mate.ku...@canonical.com, pjo...@redhat.com,
ross.philip...@oracle.com, 93...@debian.org, phco...@gmail.com
Subject: [PATCH v4 2/4] blsuki: Add blscfg command to parse Boot
Loader Specific
From: Peter Jones
The BootLoaderSpec (BLS) defines a scheme where different bootloaders can
share a format for boot items and a configuration directory that accepts
these common configurations as drop-in files.
The BLS Specification:
https://uapi-group.org/specifications/specs/boot_loader_specif
