Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-24 Thread Daniel Kiper
On Wed, Jan 23, 2019 at 05:15:58PM +, Leif Lindholm wrote: > On Wed, Jan 23, 2019 at 05:53:00PM +0100, Daniel Kiper wrote: > > On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > > > On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > > > > On 17.01.19 13:24, Daniel K

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Colin Watson
On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > I mean, that would superficially seem like the right thing to do, but > I'd really be happy with either. I haven't really managed to find a > natural pattern to where grub_errno is supposed to be used/set and not. There's an "Error H

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Leif Lindholm
On Wed, Jan 23, 2019 at 05:53:00PM +0100, Daniel Kiper wrote: > On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > > On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > > > On 17.01.19 13:24, Daniel Kiper wrote: > > > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Daniel Kiper
On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > > On 17.01.19 13:24, Daniel Kiper wrote: > > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: [...] > > >> + return GRUB_ERR_NONE; > > >> + > > >> +

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Leif Lindholm
On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > On 17.01.19 13:24, Daniel Kiper wrote: > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > >> We currently only support to run grub on RISC-V as UEFI payload. Ideally, > >> we also only want to support running Linux

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Daniel Kiper
On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > On 17.01.19 13:24, Daniel Kiper wrote: > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > >> We currently only support to run grub on RISC-V as UEFI payload. Ideally, > >> we also only want to support running Linux

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-22 Thread Alexander Graf
On 17.01.19 13:24, Daniel Kiper wrote: > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: >> We currently only support to run grub on RISC-V as UEFI payload. Ideally, >> we also only want to support running Linux underneath as UEFI payload. >> >> Prepare that with a Linux boot cas

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-18 Thread Daniel Kiper
On Thu, Jan 17, 2019 at 02:50:19PM +, Leif Lindholm wrote: > On Thu, Jan 17, 2019 at 01:24:29PM +0100, Daniel Kiper wrote: > > > +static grub_err_t > > > +finalize_params_linux (void) > > > +{ > > > + int node, retval; > > > + > > > > Please drop this empty line. > > > > > + void *fdt; > > >

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-17 Thread Leif Lindholm
On Thu, Jan 17, 2019 at 01:24:29PM +0100, Daniel Kiper wrote: > > +static grub_err_t > > +finalize_params_linux (void) > > +{ > > + int node, retval; > > + > > Please drop this empty line. > > > + void *fdt; > > + > > + fdt = grub_fdt_load (0x400); > > Why this number? Please define constant

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > we also only want to support running Linux underneath as UEFI payload. > > Prepare that with a Linux boot case that is not enabled in Linux yet. At > least i

[PATCH v4 06/10] RISC-V: Add Linux load logic

2018-11-25 Thread Alexander Graf
We currently only support to run grub on RISC-V as UEFI payload. Ideally, we also only want to support running Linux underneath as UEFI payload. Prepare that with a Linux boot case that is not enabled in Linux yet. At least it will give people something to test against when they enable the Linux U