Re: [PATCH v4 02/15] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:38:18AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:22PM -0600, Glenn Washburn wrote: > > This makes it clear that the offset represents sectors, not bytes, in order > > to improve readability. > > > > Signed-off-by: Glenn Washburn > > Reviewed-by: P

Re: [PATCH v4 02/15] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.

2020-11-15 Thread Patrick Steinhardt
On Fri, Nov 06, 2020 at 10:44:22PM -0600, Glenn Washburn wrote: > This makes it clear that the offset represents sectors, not bytes, in order > to improve readability. > > Signed-off-by: Glenn Washburn Reviewed-by: Patrick Steinhardt > --- > grub-core/disk/cryptodisk.c | 10 +- > grub

[PATCH v4 02/15] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.

2020-11-06 Thread Glenn Washburn
This makes it clear that the offset represents sectors, not bytes, in order to improve readability. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 10 +- grub-core/disk/geli.c | 2 +- grub-core/disk/luks.c | 4 ++-- grub-core/disk/luks2.c | 4 ++-- in