Re: [PATCH v4 02/11] xen: avoid memleaks on error

2016-02-25 Thread Andrei Borzenkov
22.02.2016 11:24, Daniel Kiper пишет: > > Are you sure that grub_errno is always set to GRUB_ERR_NONE > if any GRUB2 function finished successfully? grub_errno is reset by command parser before command execution (or after previous command finished actually). During command execution there is no g

Re: [PATCH v4 02/11] xen: avoid memleaks on error

2016-02-22 Thread Juergen Gross
On 22/02/16 09:24, Daniel Kiper wrote: > On Mon, Feb 22, 2016 at 07:03:10AM +0100, Juergen Gross wrote: >> When loading a Xen pv-kernel avoid memory leaks in case of errors. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/loader/i386/xen.c| 2 +- >> grub-core/loader/i386/xen_fileX

Re: [PATCH v4 02/11] xen: avoid memleaks on error

2016-02-22 Thread Daniel Kiper
On Mon, Feb 22, 2016 at 07:03:10AM +0100, Juergen Gross wrote: > When loading a Xen pv-kernel avoid memory leaks in case of errors. > > Signed-off-by: Juergen Gross > --- > grub-core/loader/i386/xen.c| 2 +- > grub-core/loader/i386/xen_fileXX.c | 17 +++-- > 2 files changed,

[PATCH v4 02/11] xen: avoid memleaks on error

2016-02-21 Thread Juergen Gross
When loading a Xen pv-kernel avoid memory leaks in case of errors. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen.c| 2 +- grub-core/loader/i386/xen_fileXX.c | 17 +++-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/grub-core/loader/i386/xen.c b