Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-11-06 Thread Philip Hands
Tested-by: Philip Hands (first-time incompetence with git send-email lost this from previous mail) ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-11-05 Thread Philip Hands
Having applied the patches from: 20231018030347.36174-1-n...@vault24.org 20231026095339.31802-1-ail...@suse.com and then used the result to build Debian-Installer, as seen here: https://salsa.debian.org/philh/grub2/-/pipelines/596346 D-I's ability to install a system using an XFS file sys

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-11-01 Thread Marta Lewandowska
On 10/18/23 05:03, Jon DeVree wrote: The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the multiple extent

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-25 Thread Daniel Kiper
On Tue, Oct 24, 2023 at 08:46:03AM +0200, Marta Lewandowska wrote: > Hi, > I also applied both patches, and tested them on aarch64, ppc64le, and > on x64 UEFI and BIOS. Machines were all able to boot, and ournormal > gating tests passed. Cool! Thanks a lot for running the tests. May I add "Tested-

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-23 Thread Marta Lewandowska
Hi, I also applied both patches, and tested them on aarch64, ppc64le, and on x64 UEFI and BIOS. Machines were all able to boot, and ournormal gating tests passed. -marta On 10/18/23 18:23, Daniel Kiper wrote: Adding Marta and Sebastian... On Tue, Oct 17, 2023 at 11:03:47PM -0400, Jon DeVree

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-23 Thread Daniel Kiper
On Sun, Oct 22, 2023 at 06:11:52PM +0200, Sebastian Andrzej Siewior wrote: > On 2023-10-18 18:23:25 [+0200], Daniel Kiper wrote: > > Marta, Sebastian, could you test this patch and patch [1] together? > > I confirm that I applied > - fs/xfs: Fix XFS directory extent parsing > from 2023101803034

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-22 Thread Sebastian Andrzej Siewior
On 2023-10-18 18:23:25 [+0200], Daniel Kiper wrote: > Marta, Sebastian, could you test this patch and patch [1] together? I confirm that I applied - fs/xfs: Fix XFS directory extent parsing from 20231018030347.36174-1-n...@vault24.org - fs/xfs: Incorrect short form directory data boundary chec

Re: [PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-18 Thread Daniel Kiper
Adding Marta and Sebastian... On Tue, Oct 17, 2023 at 11:03:47PM -0400, Jon DeVree wrote: > The XFS directory entry parsing code has never been completely correct > for extent based directories. The parser correctly handles the case > where the directory is contained in a single extent, but then m

[PATCH v4] fs/xfs: Fix XFS directory extent parsing

2023-10-17 Thread Jon DeVree
The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the multiple extent case are each identical to the single e