Re: [PATCH v4][ 5/6] cryptodisk: enable the backends to implement key files

2020-06-11 Thread Denis 'GNUtoo' Carikli
On Mon, 8 Jun 2020 20:50:15 +0200 Patrick Steinhardt wrote: > > + if (requested_keyfile_size) > > + { > > + if (requested_keyfile_size > (keyfile->size - > > keyfile_offset)) > > + return grub_error (GRUB_ERR_FILE_READ_ERROR, > > + N_("Keyfile is too smal

Re: [PATCH v4][ 5/6] cryptodisk: enable the backends to implement key files

2020-06-08 Thread Patrick Steinhardt
On Thu, Jun 04, 2020 at 05:43:23AM +0200, Denis 'GNUtoo' Carikli wrote: > @@ -1112,6 +1117,88 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int > argc, char **args) > hdr = NULL; > >have_it = 0; > + key = NULL; > + > + if (state[4].set) /* keyfile */ > +{ > + const cha

[PATCH v4][ 5/6] cryptodisk: enable the backends to implement key files

2020-06-03 Thread Denis 'GNUtoo' Carikli
From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, patch split, small fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- Changelog since v3: --- - Fixed the size formating with PRIuGRUB_SIZE - Added Reviewed-