Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-12-03 Thread Daniel Kiper
On Thu, Dec 02, 2021 at 12:51:09AM -0600, Glenn Washburn wrote: > On Thu, 18 Nov 2021 15:25:44 +0100 > Daniel Kiper wrote: > > > On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote: > > > The member found_uuid was never used by the crypto-backends, but was used > > > to > > > > Ha! Cou

Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-12-01 Thread Glenn Washburn
On Thu, 18 Nov 2021 15:25:44 +0100 Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote: > > The member found_uuid was never used by the crypto-backends, but was used to > > Ha! Could you make this patch second in this patch series? Then we could > avoid carrying

Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-11-18 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote: > The member found_uuid was never used by the crypto-backends, but was used to Ha! Could you make this patch second in this patch series? Then we could avoid carrying over have_it/found_uuid cruft over succeeding patches. > determine

[PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-10-12 Thread Glenn Washburn
The member found_uuid was never used by the crypto-backends, but was used to determine if a crypto-backend successfully mounted a cryptodisk with a given uuid. This is not needed however, because grub_device_iterate will return 1 iff grub_cryptodisk_scan_device returns 1. And grub_cryptodisk_scan_d