Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-15 Thread Thomas Schmitt
Hi, Andrei Borzenkov wrote: > I am not sure we should stretch reproducible builds that far. ISO > image created by grub-mkrescue is not binary. I was approached by Debian's reproducible-builds project because they wanted to be able to create reproducible test ISOs. http://lists.alioth.debian.o

Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-15 Thread Vladimir 'phcoder' Serbinenko
Le 15 déc. 2015 4:46 PM, "Andrei Borzenkov" a écrit : > > 14.12.2015 18:22, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > On 04.12.2015 19:32, Alexander Couzens wrote: > >> The uuid generation is based on the time. > >> --- > >> util/grub-mkrescue.c | 16 +++- > >> 1 file ch

Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-15 Thread Andrei Borzenkov
14.12.2015 18:22, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 04.12.2015 19:32, Alexander Couzens wrote: >> The uuid generation is based on the time. >> --- >> util/grub-mkrescue.c | 16 +++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> > This breaks uniqueness assumptio

Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.12.2015 19:32, Alexander Couzens wrote: > The uuid generation is based on the time. > --- > util/grub-mkrescue.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > This breaks uniqueness assumptions for UUID and we use UUID to find the right disk, as it's not possibl

[PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-04 Thread Alexander Couzens
The uuid generation is based on the time. --- util/grub-mkrescue.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index 4511826..1af1da2 100644 --- a/util/grub-mkrescue.c +++ b/util/grub-mkrescue.c @@ -52,6 +52,7 @@