Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-15 Thread Vladimir 'phcoder' Serbinenko
On Mon, 15 Feb 2016 04:42 Andrei Borzenkov wrote: > 14.02.2016 23:58, Seth Goldberg пишет: > > > > > >> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko > >> wrote: > >> > >> > >> > >> Le dim. 14 févr. 2016 14:21, Shea Levy a écrit > >> : > >>> This patch uses grub_file_open, but the

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Seth Goldberg
> On Feb 14, 2016, at 7:41 PM, Andrei Borzenkov wrote: > > 14.02.2016 23:58, Seth Goldberg пишет: >> >> >>> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >>> >>> Le dim. 14 févr. 2016 14:21, Shea Levy a écrit >>> : This patch uses grub_file_open, but

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Andrei Borzenkov
14.02.2016 23:58, Seth Goldberg пишет: > > >> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko >> wrote: >> >> >> >> Le dim. 14 févr. 2016 14:21, Shea Levy a écrit >> : >>> This patch uses grub_file_open, but the android bootimg is a >>> disk, not a file. You mentioned something ab

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Seth Goldberg
> On Feb 14, 2016, at 5:26 AM, Vladimir 'phcoder' Serbinenko > wrote: > > > > Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : >> This patch uses grub_file_open, but the android bootimg is a disk, not >> a file. You mentioned something about file_offset_open, but that also >> expects an inp

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Andrei Borzenkov
14.02.2016 16:26, Vladimir 'phcoder' Serbinenko пишет: > Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : > >> This patch uses grub_file_open, but the android bootimg is a disk, not >> a file. You mentioned something about file_offset_open, but that also >> expects an input file, not a disk. Shou

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Vladimir 'phcoder' Serbinenko
Le dim. 14 févr. 2016 14:21, Shea Levy a écrit : > This patch uses grub_file_open, but the android bootimg is a disk, not > a file. You mentioned something about file_offset_open, but that also > expects an input file, not a disk. Should I modify your patch with my > code I wrote to create a grub

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-14 Thread Shea Levy
This patch uses grub_file_open, but the android bootimg is a disk, not a file. You mentioned something about file_offset_open, but that also expects an input file, not a disk. Should I modify your patch with my code I wrote to create a grub_file_t from an android_bootimg disk device, or is ther

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-13 Thread Andrei Borzenkov
13.02.2016 00:16, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 12.02.2016 20:34, Shea Levy wrote: >> > OK. Do you have any thoughts on how best to extract the "load the kernel >> > and set the command line to a specific string" functionality out of the >> > linux command, then? >> > > At firs

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 12.02.2016 20:34, Shea Levy wrote: > OK. Do you have any thoughts on how best to extract the "load the kernel > and set the command line to a specific string" functionality out of the > linux command, then? > At first I wanted to write a short skeleton patch to show what I meant but once skelet

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-12 Thread Shea Levy
OK. Do you have any thoughts on how best to extract the "load the kernel and set the command line to a specific string" functionality out of the linux command, then? On 2016-02-12 14:22, Vladimir 'phcoder' Serbinenko wrote: Separate command is better as it keeps interface tidy and unpoluted, d

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-12 Thread Vladimir 'phcoder' Serbinenko
Separate command is better as it keeps interface tidy and unpoluted, decreasing maintenance cost. Correct me if I'm wrong but it should be clear from context of file is Android image or usual linux one? Le ven. 12 févr. 2016 20:19, Shea Levy a écrit : > On 2016-02-12 12:50, Vladimir 'φ-coder/phc

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-12 Thread Shea Levy
On 2016-02-12 12:50, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 08.02.2016 21:47, Shea Levy wrote: --- grub-core/loader/i386/linux.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux

Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.02.2016 21:47, Shea Levy wrote: > --- > grub-core/loader/i386/linux.c | 27 +-- > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c > index fddcc46..6ab8d3c 100644 > --- a/grub-core/loader/

[PATCH v3 2/3] i386: Add support for loading from android bootimg

2016-02-08 Thread Shea Levy
--- grub-core/loader/i386/linux.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c index fddcc46..6ab8d3c 100644 --- a/grub-core/loader/i386/linux.c +++ b/grub-core/loader/i386/linux.c @@