Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages.

2020-10-23 Thread Patrick Steinhardt
On Fri, Oct 23, 2020 at 02:08:18PM +0200, Daniel Kiper wrote: > On Mon, Oct 19, 2020 at 06:09:49PM -0500, Glenn Washburn wrote: > > When looping over the digests and segments, the loop variable is j, but the > > variable i is used to index in the the digests and segments json array. The > > variabl

Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages.

2020-10-23 Thread Daniel Kiper
On Mon, Oct 19, 2020 at 06:09:49PM -0500, Glenn Washburn wrote: > When looping over the digests and segments, the loop variable is j, but the > variable i is used to index in the the digests and segments json array. The > variable i is the keyslot index. Similarly, there are several grub_error() >

[PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages.

2020-10-19 Thread Glenn Washburn
When looping over the digests and segments, the loop variable is j, but the variable i is used to index in the the digests and segments json array. The variable i is the keyslot index. Similarly, there are several grub_error() statements using the wrong index in constructing the error string. Sign