Hi,
Glenn Washburn wrote:
> Why does only one suffice? It
> sounds like they test different code paths. Is it possible that there
> is a future code regression such that one iso succeeds and the other
> fails?
They follow different code paths before hunk 4 of patch 5 fixes the
bug that CE and ST
On Fri, 27 Jan 2023 11:56:50 +0100
"Thomas Schmitt" wrote:
> Hi,
>
> i wrote:
> > > So it would be better to add one or two canned images:
> > > 897 bytes of http://scdbackup.webframe.org/ce_loop.iso.gz
> > > 904 bytes of http://scdbackup.webframe.org/ce_loop2.iso.gz
>
> Glenn Washburn wrot
Hi,
i wrote:
> > So it would be better to add one or two canned images:
> > 897 bytes of http://scdbackup.webframe.org/ce_loop.iso.gz
> > 904 bytes of http://scdbackup.webframe.org/ce_loop2.iso.gz
Glenn Washburn wrote:
> These are small, I'm good with adding these images to the repository.
A
On Wed, 25 Jan 2023 21:24:00 +0100
"Thomas Schmitt" wrote:
> Hi,
>
> Daniel Kiper wrote:
> > Thomas, it would be nice if you could add the broken ISOs images
> > which you used for tests to the tests in the GRUB. If you do that
> > please CC Glenn.
>
> Is it wise to have a test which will loop
Hi,
Daniel Kiper wrote:
> Thomas, it would be nice if you could add the broken ISOs images which you
> used for tests to the tests in the GRUB. If you do that please CC Glenn.
Is it wise to have a test which will loop endlessly in case of failure ?
Is there a way to let a test time out ?
Whatev
On Fri, Jan 20, 2023 at 07:39:37PM +, Lidong Chen wrote:
> This v3 patches set addressed v2 review comments for patch 5.
> There is no changes to patch 1 to 4. Tested patch 5, the fixes
> were able to detect the endless loop, and Grub exited accordingly.
>
> Lidong Chen (5):
> fs/iso9660: Add
This v3 patches set addressed v2 review comments for patch 5.
There is no changes to patch 1 to 4. Tested patch 5, the fixes
were able to detect the endless loop, and Grub exited accordingly.
Lidong Chen (5):
fs/iso9660: Add check to prevent infinite loop
fs/iso9660: Prevent read past the end
