Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-05-10 Thread Daniel Kiper
On Sun, May 09, 2021 at 03:28:53PM +0200, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > On 4/27/21 5:35 PM, Daniel Kiper wrote: > >> Works on my ia64 machine. > >> > >> Tested-by: John Paul Adrian Glaubitz > > > > Reviewed-by: Daniel Kiper > > > > Javier, Adrian, thank you for working patient

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-05-09 Thread John Paul Adrian Glaubitz
Hi Daniel! On 4/27/21 5:35 PM, Daniel Kiper wrote: >> Works on my ia64 machine. >> >> Tested-by: John Paul Adrian Glaubitz > > Reviewed-by: Daniel Kiper > > Javier, Adrian, thank you for working patiently on this fix. Sure, no problem :-). Since this fix unbreaks grub on potentially many syst

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Daniel Kiper
On Tue, Apr 27, 2021 at 12:48:29PM +0200, John Paul Adrian Glaubitz wrote: > On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: > > Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) > > added a helper function to setup PE sections. But it also changed how the > > raw data

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
On 4/27/21 12:48 PM, John Paul Adrian Glaubitz wrote: > On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: [snip] >> } >> #endif >> + >> + if (image_target->id == IMAGE_EFI) >> +layout->kernel_size = ALIGN_UP (layout->kernel_size, >> +G

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread John Paul Adrian Glaubitz
On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: > Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) > added a helper function to setup PE sections. But it also changed how the > raw data offsets were calculated since all the section sizes are aligned. > > However, for

[PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) added a helper function to setup PE sections. But it also changed how the raw data offsets were calculated since all the section sizes are aligned. However, for some platforms, i.e ia64-efi and arm64-efi, the kernel image si