Re: [PATCH v3] Fix XFS directory extent parsing

2023-10-16 Thread Daniel Kiper
On Fri, Oct 06, 2023 at 05:58:21PM -0400, Jon DeVree wrote: > On Wed, Oct 04, 2023 at 00:43:18 +, Lidong Chen wrote: > > - if (filename + direntry->len - 1 > (char *) tail) > > + if (filename + direntry->len + 1 > (char *) end) > > return grub_error (GRUB_ERR_BAD_FS, "invalid XFS directory ent

Re: [PATCH v3] Fix XFS directory extent parsing

2023-10-06 Thread Jon DeVree
On Wed, Oct 04, 2023 at 00:43:18 +, Lidong Chen wrote: > - if (filename + direntry->len - 1 > (char *) tail) > + if (filename + direntry->len + 1 > (char *) end) > return grub_error (GRUB_ERR_BAD_FS, "invalid XFS directory entry"); > > There were these lines in the source after the diff: > >

Re: [PATCH v3] Fix XFS directory extent parsing

2023-10-03 Thread Lidong Chen
On Sep 27, 2023, at 5:43 PM, Jon DeVree wrote: The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the mult

[PATCH v3] Fix XFS directory extent parsing

2023-09-27 Thread Jon DeVree
The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the multiple extent case are each identical to the single e