Re: [PATCH v2 2/4] fs/ntfs: Correct attribute vs attribute list validation

2025-05-21 Thread Andrew Hamilton
> May I ask you to stick to the GRUB coding style? [1] I have corrected the comment style in v3. > > > + at->attr_nxt = next_attribute (at->attr_cur, at->attr_end, false); > > if ((*at->attr_cur == attr) || (attr == 0)) > > { > > grub_uint8_t *new_pos, *end; > >

Re: [PATCH v2 2/4] fs/ntfs: Correct attribute vs attribute list validation

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:16PM -0500, Andrew Hamilton wrote: > Correct ntfs_test test failures around attempting to validate attribute > list entries as attributes. The NTFS code uses common logic in some > places to parse both attributes and attribute_lists which complicates > validation. Attr

[PATCH v2 2/4] fs/ntfs: Correct attribute vs attribute list validation

2025-05-19 Thread Andrew Hamilton
Correct ntfs_test test failures around attempting to validate attribute list entries as attributes. The NTFS code uses common logic in some places to parse both attributes and attribute_lists which complicates validation. Attribute lists contain different headers including a different size of the l