Re: [PATCH v2 02/14] efi: add central copy of grub_efi_find_mmap_size

2017-08-08 Thread Leif Lindholm
On Thu, Aug 03, 2017 at 03:19:25PM +, Vladimir 'phcoder' Serbinenko wrote: > Looks good. But out of context the name is not descriptive enough. Can we > add a comment near declaration to clarify what this functions is for? Sure - will do. / Leif > Le Thu, Aug 3, 2017 à 12:07 PM, Leif Lin

Re: [PATCH v2 02/14] efi: add central copy of grub_efi_find_mmap_size

2017-08-03 Thread Vladimir 'phcoder' Serbinenko
Looks good. But out of context the name is not descriptive enough. Can we add a comment near declaration to clarify what this functions is for? Le Thu, Aug 3, 2017 à 12:07 PM, Leif Lindholm a écrit : > There are several implementations of this function in the tree. > Add a central version in gru

[PATCH v2 02/14] efi: add central copy of grub_efi_find_mmap_size

2017-08-03 Thread Leif Lindholm
There are several implementations of this function in the tree. Add a central version in grub-core/efi/mm.c. Taken from grub-core/loader/i386/linux.c, changing some hard-coded constants to use macros from efi/memory.h. Signed-off-by: Leif Lindholm --- grub-core/kern/efi/mm.c | 44 ++