Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-09 Thread Daniel Kiper
On Tue, Dec 07, 2021 at 06:27:26PM -0600, Glenn Washburn wrote: > On Tue, 7 Dec 2021 23:07:32 +0100 > Michael Schierl wrote: > > > Hello Glenn, > > > > > > Am 07.12.2021 um 22:59 schrieb Glenn Washburn: > > > Yes, but I didn't want to assume that "all" is the first item in the > > > list. > > > >

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-07 Thread Glenn Washburn
On Tue, 7 Dec 2021 23:07:32 +0100 Michael Schierl wrote: > > Hello Glenn, > > > Am 07.12.2021 um 22:59 schrieb Glenn Washburn: > > Yes, but I didn't want to assume that "all" is the first item in the > > list. > > More important, "all" does not have to be present at all. > > DEBUG=fat,btrfs,

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-07 Thread Michael Schierl
Hello Glenn, Am 07.12.2021 um 22:59 schrieb Glenn Washburn: Yes, but I didn't want to assume that "all" is the first item in the list. More important, "all" does not have to be present at all. DEBUG=fat,btrfs,-fat should be perfectly legal (and it is). I decided that it doesn't make as

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-07 Thread Glenn Washburn
On Tue, 7 Dec 2021 22:01:14 +0100 Michael Schierl wrote: > Hello Glenn, > > > Am 07.12.2021 um 10:17 schrieb Glenn Washburn: > > >> maybe move the conditional before the assignment of ret? > > > > I'm understanding you to be suggesting to move the assignment of ret to > > after the if statemen

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-07 Thread Michael Schierl
Hello Glenn, Am 07.12.2021 um 10:17 schrieb Glenn Washburn: maybe move the conditional before the assignment of ret? I'm understanding you to be suggesting to move the assignment of ret to after the if statement that follows it. Correct. The only point I see is saving an assignment in th

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-07 Thread Glenn Washburn
Hi Michael, Thanks for taking a look at this. On Mon, 6 Dec 2021 22:01:22 +0100 Michael Schierl wrote: > > Hello Glenn, > > Comments below, note that I did not test the patch so maybe I am missing > something. > > Am 06.12.2021 um 18:03 schrieb Glenn Washburn: > > > grub_debug_enabled (co

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-06 Thread Michael Schierl
Hello Glenn, Comments below, note that I did not test the patch so maybe I am missing something. Am 06.12.2021 um 18:03 schrieb Glenn Washburn: grub_debug_enabled (const char * condition) { - const char *debug; + const char *debug, *found; + grub_size_t clen; + int ret = 0; debu

[PATCH v2] misc: Allow selective disabling of debug facility names

2021-12-06 Thread Glenn Washburn
Sometimes you know only know which debug logging facility names you want to turn off, not necessarily all the ones you want enabled. This patch allows the debug string to contain facility names in the $debug variable which are prefixed with a "-" to disable debug log messages for that conditional.