On Fri, Sep 10, 2021 at 12:34:54PM +0200, Erwan Velu wrote:
> Thanks for your review, I'll rework my patch according to your comments.
> I just kept the open points in this thread.
>
> Le 09/09/2021 à 17:46, Daniel Kiper a écrit :
> >
> > +static grub_err_t grub_efi_set_watchdog_timer(unsigned long
Thanks for your review, I'll rework my patch according to your comments.
I just kept the open points in this thread.
Le 09/09/2021 à 17:46, Daniel Kiper a écrit :
+static grub_err_t grub_efi_set_watchdog_timer(unsigned long timeout)
Please use grub_efi_uintn_t instead of unsigned long. However,
On Thu, Sep 02, 2021 at 06:50:35PM +0200, Erwan Velu wrote:
> This patch got written by Arthur Mesh from Juniper (now at Apple Sec team).
> It was extracted from
> https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html
>
> Since this email, the this patch was :
> - rebased against the
Thanks !
Le mar. 7 sept. 2021 à 20:01, Daniel Kiper a écrit :
> On Tue, Sep 07, 2021 at 01:20:05PM +0200, Erwan Velu wrote:
> > Daniel, anything more about this V2 before I prepare the V3 ?
>
> I will be looking at it this week.
>
> Daniel
>
___
Grub-d
On Tue, Sep 07, 2021 at 01:20:05PM +0200, Erwan Velu wrote:
> Daniel, anything more about this V2 before I prepare the V3 ?
I will be looking at it this week.
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/
Daniel, anything more about this V2 before I prepare the V3 ?
Le ven. 3 sept. 2021 à 08:34, Erwan Velu a écrit :
> Le 03/09/2021 à 04:09, Michael Chang a écrit :
> [...]
> > I'd suggest to move this efi-watchdog command registration to
> > grub_register_core_commands() in grub-core/kern/corecmd.
Le 03/09/2021 à 04:09, Michael Chang a écrit :
[...]
I'd suggest to move this efi-watchdog command registration to
grub_register_core_commands() in grub-core/kern/corecmd.c as that helps
us tracing or knowing available commands in grub's rescue mode.
Also it would be great to see the explainatio
On Thu, Sep 02, 2021 at 06:50:35PM +0200, Erwan Velu wrote:
> This patch got written by Arthur Mesh from Juniper (now at Apple Sec team).
> It was extracted from
> https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html
>
> Since this email, the this patch was :
> - rebased against th
This patch got written by Arthur Mesh from Juniper (now at Apple Sec team).
It was extracted from
https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html
Since this email, the this patch was :
- rebased against the current tree
- added a default timeout value
- reworked to be controll
