Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-27 Thread Daniel Kiper
On Wed, May 26, 2021 at 08:18:11PM +0200, Jan Nieuwenhuizen wrote: > Daniel Kiper writes: [...] > >> * grub-core/lib/i386/relocator64.S: Avoid x86_64 instructions on i386. > > > > Hmmm... What is this? > > The "gitlog-to-changelog" scripts needs entries like this in order to > generate a GNU-comp

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-26 Thread Jan Nieuwenhuizen
Daniel Kiper writes: Hello, > Mostly nits... Please take a look below... Great! > On Tue, May 18, 2021 at 12:47:33PM +0200, Jan (janneke) Nieuwenhuizen wrote: >> To reproduce, update the Grub source description in your local Guix > > s/Grub/GRUB/ Ok. >> or install an x86 cross-build environme

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-26 Thread Daniel Kiper
Mostly nits... Please take a look below... On Tue, May 18, 2021 at 12:47:33PM +0200, Jan (janneke) Nieuwenhuizen wrote: > This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux. > > To reproduce, update the Grub source description in your local Guix s/Grub/GRUB/ > archive and run > >

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread Matt Turner
On Tue, May 18, 2021 at 3:48 AM Jan (janneke) Nieuwenhuizen wrote: > > This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux. > > To reproduce, update the Grub source description in your local Guix > archive and run > >./pre-inst-env guix build --system=i686-linux --target=i586-pc-

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread John Paul Adrian Glaubitz
On 5/18/21 4:35 PM, John Paul Adrian Glaubitz wrote: > So I'm not sure what kind of host system we are talking about here? This looks > more like a configuration issue of the distribution in question which > deliberately > builds its 32-bit toolchain without 64-bit support. Hmm, I just noticed th

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread John Paul Adrian Glaubitz
Hi Daniel! On 5/18/21 4:26 PM, Daniel Kiper wrote: > When I was looking at the issue first time I thought in the same way. > Though after some thinking I realized that it is perfectly valid to > start 64-bit kernel from 32-bit bootloader which was build in 32-bit > environment. So, I think it make

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread Daniel Kiper
Hey Adrian, On Tue, May 18, 2021 at 12:58:07PM +0200, John Paul Adrian Glaubitz wrote: > Hello Jan! > > On 5/18/21 12:47 PM, Jan (janneke) Nieuwenhuizen wrote: > > or install an x86 cross-build environment on x86-linux (32bit!) and > > configure to cross build and make, e.g., do something like > >

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread John Paul Adrian Glaubitz
Hello Jan! On 5/18/21 12:47 PM, Jan (janneke) Nieuwenhuizen wrote: > or install an x86 cross-build environment on x86-linux (32bit!) and > configure to cross build and make, e.g., do something like Are we talking about a toolchain which exclusively supports 32-bit builds only? If yes, wouldn't it

[PATCH v2] grub-core: Build fixes for i386

2021-05-18 Thread Jan (janneke) Nieuwenhuizen
This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux. To reproduce, update the Grub source description in your local Guix archive and run ./pre-inst-env guix build --system=i686-linux --target=i586-pc-gnu grub or install an x86 cross-build environment on x86-linux (32bit!) and co