Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-10-16 Thread Gary Lin via Grub-devel
On Wed, Oct 16, 2024 at 05:44:29PM +0200, Daniel Kiper wrote: > On Fri, Sep 06, 2024 at 05:11:14PM +0800, Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > > > The TPM2 key protector is a module that enables the automatic retrieval > > of a fully-encrypted disk's unlocking key from a TPM 2

Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-10-16 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:11:14PM +0800, Gary Lin via Grub-devel wrote: > From: Hernan Gatta > > The TPM2 key protector is a module that enables the automatic retrieval > of a fully-encrypted disk's unlocking key from a TPM 2.0. > > The theory of operation is such that the module accepts various

Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-09-19 Thread Gary Lin via Grub-devel
On Thu, Sep 19, 2024 at 11:05:13AM -0400, Stefan Berger wrote: > > > On 9/19/24 3:45 AM, Gary Lin wrote: > > On Wed, Sep 18, 2024 at 11:22:16AM -0400, Stefan Berger wrote: > > > > > > > > > > *handle = (TPM_HANDLE_t) num; > > > > > How about this change? > > > > - return grub_error (GRUB

Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-09-19 Thread Stefan Berger
On 9/19/24 3:45 AM, Gary Lin wrote: On Wed, Sep 18, 2024 at 11:22:16AM -0400, Stefan Berger wrote: *handle = (TPM_HANDLE_t) num; How about this change? - return grub_error (GRUB_ERR_OUT_OF_RANGE, "Value %lu is too large to be a TPM handle, TPM handles are unsigned 32-bit integers"

Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-09-19 Thread Gary Lin via Grub-devel
On Wed, Sep 18, 2024 at 11:22:16AM -0400, Stefan Berger wrote: > > > On 9/6/24 5:11 AM, Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > > > The TPM2 key protector is a module that enables the automatic retrieval > > of a fully-encrypted disk's unlocking key from a TPM 2.0. > > > > Th

Re: [PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-09-18 Thread Stefan Berger
On 9/6/24 5:11 AM, Gary Lin via Grub-devel wrote: From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are

[PATCH v19 22/33] key_protector: Add TPM2 Key Protector

2024-09-06 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On