Re: [PATCH v18 21/25] cryptodisk: Fallback to passphrase

2024-09-02 Thread Gary Lin via Grub-devel
On Fri, Aug 30, 2024 at 06:10:28PM +0200, Daniel Kiper wrote: > On Fri, Jun 28, 2024 at 04:19:04PM +0800, Gary Lin via Grub-devel wrote: > > From: Patrick Colp > > > > If a protector is specified, but it fails to unlock the disk, fall back > > to asking for the passphrase. However, an error was se

Re: [PATCH v18 21/25] cryptodisk: Fallback to passphrase

2024-08-30 Thread Daniel Kiper
On Fri, Jun 28, 2024 at 04:19:04PM +0800, Gary Lin via Grub-devel wrote: > From: Patrick Colp > > If a protector is specified, but it fails to unlock the disk, fall back > to asking for the passphrase. However, an error was set indicating that > the protector(s) failed. Later code (e.g., LUKS code

[PATCH v18 21/25] cryptodisk: Fallback to passphrase

2024-06-28 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr