Re: [PATCH v18 12/25] key_protector: Add key protectors framework

2024-06-30 Thread Gary Lin via Grub-devel
On Fri, Jun 28, 2024 at 02:54:53PM +0300, Vladimir 'phcoder' Serbinenko wrote: > > + if (protector == NULL || protector->name == NULL || grub_strlen > > (protector->name) == 0) > > +return GRUB_ERR_BAD_ARGUMENT; > > + > Here and in the other places you miss grub_error. Note that the > message

Re: [PATCH v18 12/25] key_protector: Add key protectors framework

2024-06-28 Thread Vladimir 'phcoder' Serbinenko
> + if (protector == NULL || protector->name == NULL || grub_strlen > (protector->name) == 0) > +return GRUB_ERR_BAD_ARGUMENT; > + Here and in the other places you miss grub_error. Note that the message in such technical cases should be left untranslated (no N_ mark). > + if (protector == N

[PATCH v18 12/25] key_protector: Add key protectors framework

2024-06-28 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma