Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-15 Thread Neal Gompa
On Tue, Oct 8, 2024 at 2:59 AM Michael Chang via Grub-devel wrote: > > On Mon, Oct 07, 2024 at 09:40:40PM GMT, Vladimir 'phcoder' Serbinenko wrote: > > What do you try to achieve with this that can't be achieved with using full > > path? We should avoid using hidden state for directory parsing. So

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-07 Thread Michael Chang via Grub-devel
On Mon, Oct 07, 2024 at 09:40:40PM GMT, Vladimir 'phcoder' Serbinenko wrote: > What do you try to achieve with this that can't be achieved with using full > path? We should avoid using hidden state for directory parsing. Solaris > GRUB legacy used it for ZFS and it was a mess. If a path is relativ

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-07 Thread Vladimir 'phcoder' Serbinenko
What do you try to achieve with this that can't be achieved with using full path? We should avoid using hidden state for directory parsing. Solaris GRUB legacy used it for ZFS and it was a mess. Le lun. 7 oct. 2024, 21:22, Leo Sandoval a écrit : > From: Michael Chang > > Signed-off-by: Michael

[PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-07 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c| 195 +++- grub-core/osdep/linux/getroot.c | 148 +++- include/grub/emu/getroot.h | 5 + util/grub-install.c |