Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-29 Thread Daniel Axtens
Daniel Kiper writes: > On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote: >> Charles Duffy writes: >> >> > Amended the test repo to apply this patch; it applies and works-as-intended >> > on both 2.04 and current master. >> > >> > As for the DCO assertions, my portion of the contribu

Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-29 Thread Daniel Kiper
On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote: > Charles Duffy writes: > > > Amended the test repo to apply this patch; it applies and works-as-intended > > on both 2.04 and current master. > > > > As for the DCO assertions, my portion of the contribution was implemented > > strict

Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-28 Thread Daniel Axtens
Charles Duffy writes: > Amended the test repo to apply this patch; it applies and works-as-intended > on both 2.04 and current master. > > As for the DCO assertions, my portion of the contribution was implemented > strictly on personal time/equipment, so I'm able to to make the relevant > asserti

Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-28 Thread Charles Duffy
Amended the test repo to apply this patch; it applies and works-as-intended on both 2.04 and current master. As for the DCO assertions, my portion of the contribution was implemented strictly on personal time/equipment, so I'm able to to make the relevant assertions in my individual capacity; amen

[PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-28 Thread Daniel Axtens
Currently GRUB2 verify logic searches PGP keyid only in unhashed subpackets of PGP signature packet. As a result, signatures generated with GoLang openpgp package (https://godoc.org/golang.org/x/crypto/openpgp) could not be verified, because this package puts keyid in hashed subpackets and GRUB cod