[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-10-18 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-10-11 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-09-27 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

Re: [PATCH 6/9] btrfs: Refactor the code that read from disk

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 07:39:53PM +0200, Goffredo Baroncelli wrote: > Move the code in charge to read the data from disk into a separate > function. This helps to separate the error handling logic (which depend on s/depend/depends/ > the different raid profiles) from the read from disk logic. >

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-06-19 Thread Goffredo Baroncelli
Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depend on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This is a preparatory patch, to hel

Re: [PATCH 6/9] btrfs: Refactor the code that read from disk

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:45PM +0200, Goffredo Baroncelli wrote: > Move the code in charge to read the data from disk in a separate s/in a/into a/ > function. This helps to separate the error handling logic (which depend by s/depend by/depends on/ Please fix this here and in other patches to

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-06-03 Thread Goffredo Baroncelli
Move the code in charge to read the data from disk in a separate function. This helps to separate the error handling logic (which depend by the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This is a preparatory patch, to help

Re: [PATCH 6/9] btrfs: refactor the code that read from disk

2018-06-01 Thread Goffredo Baroncelli
On 05/30/2018 01:07 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:16PM +0200, Goffredo Baroncelli wrote: >> This is a preparatory patch, to help the adding of the RAID 5/6 recovery > > Please move "This is a preparatory patch" sentence below... > >> code. In case of availability of all

Re: [PATCH 6/9] btrfs: refactor the code that read from disk

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:16PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the RAID 5/6 recovery Please move "This is a preparatory patch" sentence below... > code. In case of availability of all disks, this code is good for all the > RAID profiles.

[PATCH 6/9] btrfs: refactor the code that read from disk

2018-05-16 Thread Goffredo Baroncelli
This is a preparatory patch, to help the adding of the RAID 5/6 recovery code. In case of availability of all disks, this code is good for all the RAID profiles. However in case of failure, the error handling is quite different. Refactoring this code increases the general readability. Signed-off-b