Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-31 Thread Ian Campbell
On Tue, 2013-12-31 at 15:19 +0100, Francesco Lavra wrote: > On 12/29/2013 07:47 PM, Ian Campbell wrote: > > diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c > > index b4216ff..186d259 100644 > > --- a/util/grub-mkimagexx.c > > +++ b/util/grub-mkimagexx.c > > @@ -378,6 +378,7 @@ SUFFIX (re

Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-31 Thread Francesco Lavra
On 12/29/2013 07:47 PM, Ian Campbell wrote: > diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c > index b4216ff..186d259 100644 > --- a/util/grub-mkimagexx.c > +++ b/util/grub-mkimagexx.c > @@ -378,6 +378,7 @@ SUFFIX (relocate_symbols) (Elf_Ehdr *e, Elf_Shdr > *sections, >

Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-30 Thread Andrey Borzenkov
В Вс, 29/12/2013 в 18:47 +, Ian Campbell пишет: > @@ -1530,9 +1551,9 @@ SUFFIX (load_image) (const char *kernel_path, size_t > *exec_size, >for (i = 0; i < num_sections; i++) > section_vaddresses[i] = section_addresses[i] + > image_target->vaddr_offset; > > - if (!grub_image_needs

Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-30 Thread Ian Campbell
On Sun, 2013-12-29 at 22:53 +, Leif Lindholm wrote: > > diff --git a/util/grub-mkimage.c b/util/grub-mkimage.c > > index a2bd4c1..267beaa 100644 > > --- a/util/grub-mkimage.c > > +++ b/util/grub-mkimage.c > > @@ -65,6 +65,7 @@ static struct argp_option options[] = { > > /* TRANSLATORS: plat

Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.12.2013 23:53, Leif Lindholm wrote: > For this to actually print a default value, you need to also update > the help_filter function. Also, you probably want a %p here. This is not a pointer in the address space of running process, so %p is not the right qualifier for it. 0x%x if needed only

Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-29 Thread Leif Lindholm
On Sun, Dec 29, 2013 at 06:47:35PM +, Ian Campbell wrote: > To do so support the specification of a "target_address" (which must be 0 for > image types which do not have this flag) and a new image flag to signal the > need for absolute relocation. If this flag is present then image->link_addr i

[PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-29 Thread Ian Campbell
To do so support the specification of a "target_address" (which must be 0 for image types which do not have this flag) and a new image flag to signal the need for absolute relocation. If this flag is present then image->link_addr is the default target. Account for the target address when relocatin