Re: [PATCH 4/4] xfs: V5 filesystem format support

2015-05-13 Thread Jan Kara
On Wed 13-05-15 07:50:38, Andrei Borzenkov wrote: > В Tue, 12 May 2015 15:47:40 +0200 > Jan Kara пишет: > > > + > > > > +static grub_uint64_t * > > > > +grub_xfs_btree_keys(struct grub_xfs_data *data, > > > > + struct grub_xfs_btree_node *leaf) > > > > +{ > > > > + char *p = (ch

Re: [PATCH 4/4] xfs: V5 filesystem format support

2015-05-12 Thread Andrei Borzenkov
В Tue, 12 May 2015 15:47:40 +0200 Jan Kara пишет: > > > +{ > > > + return ((grub_uint8_t *)(de + 1)) + de->len - 1 + > > The outer parens are somehow confusing. > > I can remove them but I find it better to explicitely show where the > typecast happens with parenthesis... > OK > > + > > > +

Re: [PATCH 4/4] xfs: V5 filesystem format support

2015-05-12 Thread Jan Kara
On Tue 12-05-15 08:23:40, Andrei Borzenkov wrote: ... > > @@ -123,17 +144,6 @@ struct grub_xfs_inode > >grub_uint16_t unused3; > >grub_uint8_t fork_offset; > >grub_uint8_t unused4[17]; > > - union > > - { > > -char raw[156]; > > -struct dir > > -{ > > - struct grub_x

Re: [PATCH 4/4] xfs: V5 filesystem format support

2015-05-11 Thread Andrei Borzenkov
В Mon, 14 Jul 2014 17:21:31 +0200 Jan Kara пишет: > Add support for new XFS on disk format. We have to handle optional > filetype fields in directory entries, additional CRC, LSN, UUID entries > in some structures, etc. > > Signed-off-by: Jan Kara > --- > grub-core/fs/xfs.c | 249 > ++

[PATCH 4/4] xfs: V5 filesystem format support

2014-07-14 Thread Jan Kara
Add support for new XFS on disk format. We have to handle optional filetype fields in directory entries, additional CRC, LSN, UUID entries in some structures, etc. Signed-off-by: Jan Kara --- grub-core/fs/xfs.c | 249 + 1 file changed, 177 inse