Re: [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary

2022-12-20 Thread Thomas Schmitt
Hi, in summary: Your objections to my objections are correct. On Wed, 14 Dec 2022 18:55:05 + Lidong Chen wrote: > >> + /* The symlink is not stored as a POSIX symlink, translate it. */ > >> + while ((pos + GRUB_ISO9660_SUSP_HEADER_SZ) < entry->len) On Dec 15, 2022, at 10:20 AM, T

Re: [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary

2022-12-19 Thread Lidong Chen
> On Dec 15, 2022, at 10:20 AM, Thomas Schmitt wrote: > > Hi, > > On Wed, 14 Dec 2022 18:55:05 + Lidong Chen wrote: >> [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary > > s/boudary/boundary/ > >> An entry consists of the entry info and the

Re: [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary

2022-12-15 Thread Thomas Schmitt
Hi, On Wed, 14 Dec 2022 18:55:05 + Lidong Chen wrote: > [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary s/boudary/boundary/ > An entry consists of the entry info and the component area. Component area is specific to the RRIP SL entry. So: s/An entry/An SL entry/ >

[PATCH 4/4] fs/iso9660: Incorrect check for entry boudary

2022-12-14 Thread Lidong Chen
An entry consists of the entry info and the component area. The entry info should take up 5 bytes instead of sizeof (*entry). The area after the first 5 bytes is the component area. The code uses the sizeof (*entry) to check the boundary which is incorrect. Also, an entry may not have component rec