Re: [PATCH 3/5] loader/i386/linux: Fix resource leak

2025-03-27 Thread Daniel Kiper via Grub-devel
On Thu, Mar 27, 2025 at 09:19:03PM +0300, Vladimir 'phcoder' Serbinenko wrote: > > +      { > +       grub_errno = err; > +       goto fail; > +      } > grub_errno is already set. No need to set it again  I proposed that assignment to make it explicit but I am not going to ins

Re: [PATCH 3/5] loader/i386/linux: Fix resource leak

2025-03-27 Thread Vladimir 'phcoder' Serbinenko
> > > + { > + grub_errno = err; > + goto fail; > + } > grub_errno is already set. No need to set it again > initrd_mem = get_virtual_current_address (ch); > initrd_mem_target = get_physical_target_address (ch); >} > -- > 2.34.1 > > >

[PATCH 3/5] loader/i386/linux: Fix resource leak

2025-03-27 Thread Lidong Chen via Grub-devel
In grub_cmd_initrd(), initrd_ctx is allocated before calling grub_relocator_alloc_chunk_align(). When that function fails, initrd_ctx should be freed before exiting grub_cmd_initrd(). Fixes: CID 473852 Signed-off-by: Lidong Chen --- grub-core/loader/i386/linux.c | 5 - 1 file changed, 4 ins