Re: [PATCH 3/3] Core TPM support

2017-06-21 Thread Javier Martinez Canillas
Hello Matthew, On 06/16/2017 03:51 PM, Javier Martinez Canillas wrote: > > I've tested your patches (plus the verify framework) today on a Lenovo > Thinkpad X1 Carbon with 2 different setups: > I've tested today building your patches --with-platform=pc instead of efi, and found a build error du

Re: [PATCH 3/3] Core TPM support

2017-06-19 Thread Javier Martinez Canillas
On 06/19/2017 05:38 AM, Matthew Garrett wrote: > On Fri, Jun 16, 2017 at 03:51:38PM +0200, Javier Martinez Canillas wrote: > >> The TCG EFI Protocol Specification (rev 00.13, March 2016) mentions that the >> tdEFI_TCG2_BOOT_SERVICE_CAPABILITY StructureVersion Major and Minor should >> be checked

Re: [PATCH 3/3] Core TPM support

2017-06-18 Thread Matthew Garrett
On Fri, Jun 16, 2017 at 03:51:38PM +0200, Javier Martinez Canillas wrote: > The TCG EFI Protocol Specification (rev 00.13, March 2016) mentions that the > tdEFI_TCG2_BOOT_SERVICE_CAPABILITY StructureVersion Major and Minor should > be checked to determine the EFI_TCG2_BOOT_SERVICE_CAPABILITY struc

Re: [PATCH 3/3] Core TPM support

2017-06-16 Thread Javier Martinez Canillas
Hello Matthew, I've tested your patches (plus the verify framework) today on a Lenovo Thinkpad X1 Carbon with 2 different setups: a) Infineon TPM1.2 chip b) Intel PTT firmware-based TPM2.0 It works correctly in both cases, there are measurements made by grub2 on both PCR{8,9} as expected: (a)

[PATCH 3/3] Core TPM support

2017-06-15 Thread Matthew Garrett
Add support for performing basic TPM measurements. Right now this only supports extending PCRs statically and only on UEFI. --- grub-core/Makefile.am | 1 + grub-core/Makefile.core.def| 2 + grub-core/kern/efi/tpm.c | 282 + grub-core/

[PATCH 3/3] Core TPM support

2017-06-14 Thread Matthew Garrett
Add support for performing basic TPM measurements. Right now this only supports extending PCRs statically and only on UEFI. --- grub-core/Makefile.am | 1 + grub-core/Makefile.core.def| 2 + grub-core/kern/efi/tpm.c | 282 + grub-core/