Re: [PATCH 2/3] fs/fshelp: Avoid possible NULL pointer deference

2025-05-19 Thread Andrew Hamilton
Thanks I will make the suggested fixes and sent out a v2 later. - Andrew On Sat, May 17, 2025 at 6:23 AM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Another comment: ERR_BAD_FS might be a better fit given how it can be > triggered. > > Regards > > Le sam. 17 mai 2025, 14:09, Vla

Re: [PATCH 2/3] fs/fshelp: Avoid possible NULL pointer deference

2025-05-17 Thread Vladimir 'phcoder' Serbinenko
Another comment: ERR_BAD_FS might be a better fit given how it can be triggered. Regards Le sam. 17 mai 2025, 14:09, Vladimir 'phcoder' Serbinenko a écrit : > > Small comment, otherwise looks good > > Le sam. 17 mai 2025, 04:26, Andrew Hamilton a écrit : > >> Avoid attempting to defererence a

Re: [PATCH 2/3] fs/fshelp: Avoid possible NULL pointer deference

2025-05-17 Thread Vladimir 'phcoder' Serbinenko
Small comment, otherwise looks good Le sam. 17 mai 2025, 04:26, Andrew Hamilton a écrit : > Avoid attempting to defererence a NULL pointer to call read_symlink when > the given filesystem does not provide a read_symlink function. This could > be triggered if the calling filesystem had a file mar

[PATCH 2/3] fs/fshelp: Avoid possible NULL pointer deference

2025-05-16 Thread Andrew Hamilton
Avoid attempting to defererence a NULL pointer to call read_symlink when the given filesystem does not provide a read_symlink function. This could be triggered if the calling filesystem had a file marked as a symlink. This appears possible for HFS and was observed during fuzzing of NTFS. Signed-