Re: [PATCH 2/2] bash-completion:fix shellcheck warning

2022-11-29 Thread Fengtao (fengtao, Euler) via Grub-devel
On 2022/11/24 0:09, Daniel Kiper wrote: > On Mon, Sep 19, 2022 at 09:20:14AM +0800, t.feng via Grub-devel wrote: >> SC2207 (warning): Prefer mapfile or read -a to split >> command output (or quote to avoid splitting). >> SC2120 (warning): __grub_get_options_from_help references arguments, >> but

Re: [PATCH 2/2] bash-completion:fix shellcheck warning

2022-11-23 Thread Daniel Kiper
On Mon, Sep 19, 2022 at 09:20:14AM +0800, t.feng via Grub-devel wrote: > SC2207 (warning): Prefer mapfile or read -a to split > command output (or quote to avoid splitting). > SC2120 (warning): __grub_get_options_from_help references arguments, > but none are ever passed. > SC2155 (warning): Declar

[PATCH 2/2] bash-completion:fix shellcheck warning

2022-09-18 Thread t.feng via Grub-devel
SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2120 (warning): __grub_get_options_from_help references arguments, but none are ever passed. SC2155 (warning): Declare and assign separately to avoid masking return values. In grub-completion.bash.