Re: [PATCH 1/4] fs/iso9660: Add check to prevent infinite loop

2022-12-19 Thread Thomas Schmitt
Hi, i wrote: > > (Are we aware of the file size limit of 32 GiB - 14 KiB - 1 imposed by > > struct grub_fshelp_node { ... struct grub_iso9660_dir dirents[8]; ... } > > ? ) Lidong Chen wrote: > I am not familiar with this file size limit. Do we need to add a check > somewhere? Good question. Th

Re: [PATCH 1/4] fs/iso9660: Add check to prevent infinite loop

2022-12-19 Thread Lidong Chen
> On Dec 15, 2022, at 9:52 AM, Thomas Schmitt wrote: > > Hi, > > On Wed, 14 Dec 2022 18:55:02 + Lidong Chen wrote: >> There is no check for the end of block When reading > > s/When/when/ > >> directory extents. It resulted in read_node() always >> read from the same offset in the while

Re: [PATCH 1/4] fs/iso9660: Add check to prevent infinite loop

2022-12-15 Thread Thomas Schmitt
Hi, On Wed, 14 Dec 2022 18:55:02 + Lidong Chen wrote: > There is no check for the end of block When reading s/When/when/ > directory extents. It resulted in read_node() always > read from the same offset in the while loop, thus > caused infinite loop. The fix added a check for the > end of

[PATCH 1/4] fs/iso9660: Add check to prevent infinite loop

2022-12-14 Thread Lidong Chen
There is no check for the end of block When reading directory extents. It resulted in read_node() always read from the same offset in the while loop, thus caused infinite loop. The fix added a check for the end of the block and ensure the read is within directory boundary. Signed-off-by: Lidong Ch