Re: [PATCH 1/3] Import libgcrypt 1.10.3

2024-05-21 Thread Gary Lin via Grub-devel
On Tue, May 21, 2024 at 01:36:18PM +0300, Vladimir 'phcoder' Serbinenko wrote: > I think at least AUTHORS and COPYING should be included. I see the point to keep AUTHORS and COPYING but other library such minilzo only copies the essential .c/.h files. > Rest is for the ease of update in the futur

Re: [PATCH 1/3] Import libgcrypt 1.10.3

2024-05-21 Thread Vladimir 'phcoder' Serbinenko
I think at least AUTHORS and COPYING should be included. Rest is for the ease of update in the future. Le mar. 21 mai 2024, 10:32, Gary Lin a écrit : > Hi Vladimir, > > Originally, there are only cipher, mpi, and src in the libgcrypt > directory, but the unnecessary stuff, e.g. AUTHORS, COPYING,

Re: [PATCH 1/3] Import libgcrypt 1.10.3

2024-05-21 Thread Gary Lin via Grub-devel
Hi Vladimir, Originally, there are only cipher, mpi, and src in the libgcrypt directory, but the unnecessary stuff, e.g. AUTHORS, COPYING, build-aux, tests, etc., was added and bloated the size of the patch. Could you remove them and only keep the necessary files? Thanks, Gary Lin _

Re: [PATCH 1/3] Import libgcrypt 1.10.3

2024-05-17 Thread Daniel Kiper
Adding a few folks who are probably interested in this series... May I ask you to add a few words to the commit message saying why this change is needed? And please do not forget to add your SOB to this and other patches. Ah, and missing cover letter... Daniel __