Re: [PATCH 1/2] Include function name on debug traces

2025-04-23 Thread Leo Sandoval via Grub-devel
On Wed, Apr 23, 2025 at 10:30 AM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > > > Le mer. 23 avr. 2025, 01:39, Leo Sandoval a écrit : > >> >> >> On Tue, Apr 15, 2025 at 9:28 AM Vladimir 'phcoder' Serbinenko < >> phco...@gmail.com> wrote: >> >>> What is the code size increase on i38

Re: [PATCH 1/2] Include function name on debug traces

2025-04-23 Thread Vladimir 'phcoder' Serbinenko
Le mer. 23 avr. 2025, 01:39, Leo Sandoval a écrit : > > > On Tue, Apr 15, 2025 at 9:28 AM Vladimir 'phcoder' Serbinenko < > phco...@gmail.com> wrote: > >> What is the code size increase on i386-pc? Did you test it? This is >> likely to result in a big one >> > > I did not test the binary size imp

Re: [PATCH 1/2] Include function name on debug traces

2025-04-22 Thread Leo Sandoval via Grub-devel
On Tue, Apr 15, 2025 at 9:28 AM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > What is the code size increase on i386-pc? Did you test it? This is likely > to result in a big one > I did not test the binary size impact but du'ing does not show much degradation (around 24kb increase)

Re: [PATCH 1/2] Include function name on debug traces

2025-04-15 Thread Vladimir 'phcoder' Serbinenko
What is the code size increase on i386-pc? Did you test it? This is likely to result in a big one Regards Vladimir 'phcoder' Serbinenko Le sam. 12 avr. 2025, 01:03, Leo Sandoval via Grub-devel a écrit : > Together with the line number, the debug trace with the function name > provides a bit mor

Re: [PATCH 1/2] Include function name on debug traces

2025-04-15 Thread Daniel Kiper
On Fri, Apr 11, 2025 at 04:01:04PM -0600, Leo Sandoval via Grub-devel wrote: > Together with the line number, the debug trace with the function name > provides a bit more context and could be useful when inspecting log. > > Signed-off-by: Leo Sandoval Reviewed-by: Daniel Kiper Daniel _

[PATCH 1/2] Include function name on debug traces

2025-04-11 Thread Leo Sandoval via Grub-devel
Together with the line number, the debug trace with the function name provides a bit more context and could be useful when inspecting log. Signed-off-by: Leo Sandoval --- grub-core/kern/misc.c | 4 ++-- include/grub/misc.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git