Re: [PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

2023-10-18 Thread Daniel Kiper
On Thu, Sep 28, 2023 at 10:33:44PM +, Lidong Chen wrote: > After parsing of the current entry, the entry pointer is advanced > to the next entry at the end of the 'for' loop. In case where the > last entry is at the end of the data boundary, the advanced entry > pointer can point off the data b

Re: [PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

2023-10-18 Thread Daniel Kiper
On Tue, Oct 17, 2023 at 10:50:13PM -0400, Jon DeVree wrote: > On Mon, Oct 16, 2023 at 19:54:15 +0200, Daniel Kiper wrote: > > Jon, may I ask you to take a look at this patch? Does not it conflict > > with your XFS patch [1]. > > They are similar but distinct code paths. This patch is for the > XFS_

Re: [PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

2023-10-17 Thread Jon DeVree
On Mon, Oct 16, 2023 at 19:54:15 +0200, Daniel Kiper wrote: > Jon, may I ask you to take a look at this patch? Does not it conflict > with your XFS patch [1]. > They are similar but distinct code paths. This patch is for the XFS_INODE_FORMAT_INO case, my patch is for the XFS_INODE_FORMAT_EXT and

Re: [PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

2023-10-16 Thread Daniel Kiper
Jon, may I ask you to take a look at this patch? Does not it conflict with your XFS patch [1]. Daniel [1] https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00110.html On Thu, Sep 28, 2023 at 10:33:44PM +, Lidong Chen wrote: > After parsing of the current entry, the entry pointer is ad

[PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

2023-09-28 Thread Lidong Chen
After parsing of the current entry, the entry pointer is advanced to the next entry at the end of the 'for' loop. In case where the last entry is at the end of the data boundary, the advanced entry pointer can point off the data boundary. The subsequent boundary check for the advanced entry pointer