Re: [PATCH] update-grub for Cygwin

2008-08-06 Thread Christian Franke
Robert Millan wrote: On Tue, Aug 05, 2008 at 02:13:43PM +0200, Christian Franke wrote: Why not have the user write a custom entry then? I think it clutters the user interface to add options for everything. If a corner case (boot a non native disk, can't use os-prober) can be supported by cr

Re: [PATCH] update-grub for Cygwin

2008-08-05 Thread Robert Millan
On Tue, Aug 05, 2008 at 02:13:43PM +0200, Christian Franke wrote: > > > >Why not have the user write a custom entry then? I think it clutters the > >user interface to add options for everything. If a corner case (boot a non > >native disk, can't use os-prober) can be supported by creating a new c

Re: [PATCH] update-grub for Cygwin

2008-08-05 Thread Christian Franke
Robert Millan wrote: On Mon, Aug 04, 2008 at 10:40:02PM +0200, Christian Franke wrote: Robert Millan wrote: On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: Here a more generic version which allows to specifiy windows system dirs by /etc/default/grub:GRUB_WIND

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 10:40:02PM +0200, Christian Franke wrote: > Robert Millan wrote: > >On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: > > > >>Here a more generic version which allows to specifiy windows system dirs > >>by /etc/default/grub:GRUB_WINDOWS_DIRS. > >> > >>Defa

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Christian Franke
Robert Millan wrote: On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: Here a more generic version which allows to specifiy windows system dirs by /etc/default/grub:GRUB_WINDOWS_DIRS. Defaults to current SYSTEMDRIVE on Cygwin, and nothing on other OS. Christian 2008-08-04

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: > > Here a more generic version which allows to specifiy windows system dirs > by /etc/default/grub:GRUB_WINDOWS_DIRS. > > Defaults to current SYSTEMDRIVE on Cygwin, and nothing on other OS. > > Christian > > 2008-08-04 Christi

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Christian Franke
Christian Franke wrote: Robert Millan wrote: On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: + +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access

Re: [PATCH] update-grub for Cygwin

2008-07-31 Thread Christian Franke
Robert Millan wrote: On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: + +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access_device() is a much bett

Re: [PATCH] update-grub for Cygwin

2008-07-29 Thread Christian Franke
Robert Millan wrote: On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote: On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote: Robert Millan wrote: On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: + case "`uname 2>/dev/null`" in +

Re: [PATCH] update-grub for Cygwin

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote: > On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote: > > Robert Millan wrote: > > > On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: > > > > > >> + case "`uname 2>/dev/null`" in > > >> +CYGWIN*) > > >>

Re: [PATCH] update-grub for Cygwin

2008-07-26 Thread Pavel Roskin
On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote: > Robert Millan wrote: > > On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: > > > >> + case "`uname 2>/dev/null`" in > >> +CYGWIN*) > >> > > > > Could this be done at build time instead? (when generating update

Re: [PATCH] update-grub for Cygwin

2008-07-26 Thread Christian Franke
Robert Millan wrote: On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: + case "`uname 2>/dev/null`" in +CYGWIN*) Could this be done at build time instead? (when generating update-grub from update-grub.in) Yes, of course. Some alternatives: 1.) The method use

Re: [PATCH] update-grub for Cygwin

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: > + > +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access_device() is a much better option. -- Robert Millan

Re: [PATCH] update-grub for Cygwin

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: > + case "`uname 2>/dev/null`" in > +CYGWIN*) Could this be done at build time instead? (when generating update-grub from update-grub.in) -- Robert Millan I know my rights; I want my phone call! What good is a phone call…

Re: [PATCH] update-grub for Cygwin

2008-07-24 Thread Christian Franke
Christian Franke wrote: This patch allows to run update-grub on Cygwin. ... and here is a simple example for /etc/grub.d/10_cygwin Only adds current OS yet. Christian diff --git a/util/grub.d/10_cygwin.in b/util/grub.d/10_cygwin.in new file mode 100644 index 000..1dd1116 --- /dev/null ++

[PATCH] update-grub for Cygwin

2008-07-24 Thread Christian Franke
This patch allows to run update-grub on Cygwin. Christian 2008-07-24 Christian Franke <[EMAIL PROTECTED]> * util/update-grub.in: Add a check for admin group for Cygwin. Add `-f' to `rm' and `mv' of grub.cfg to handle the different filesystem semantics on Window