Re: [PATCH] unused constants in i386/boot.h

2009-07-15 Thread Pavel Roskin
On Wed, 2009-07-15 at 09:36 +0200, Yves Blusseau wrote: > Cool, i have planed to do it but if you do the job it'll be great ! It's committed. I'm looking at the sanity checks in grub-setup now. By the way, please do something about your mailer. You messages come in HTML format, which makes it

Re: [PATCH] unused constants in i386/boot.h

2009-07-15 Thread Yves Blusseau
Pavel Roskin a écrit : On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote: On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote: Quoting Yves Blusseau : As long as boot/i386/pc/boot.S has the variables whose offset these

Re: [PATCH] unused constants in i386/boot.h

2009-07-14 Thread Pavel Roskin
On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote: > On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote: > > Quoting Yves Blusseau : > > > >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros > >>> are describing, I think it's fine to keep them. > > > > I'd

Re: [PATCH] unused constants in i386/boot.h

2009-07-14 Thread Robert Millan
On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote: > Quoting Yves Blusseau : > >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros >>> are describing, I think it's fine to keep them. > > I'd rather not keep the macros that are not used outside boot.S. They >

Re: [PATCH] unused constants in i386/boot.h

2009-07-12 Thread Pavel Roskin
Quoting Yves Blusseau : As long as boot/i386/pc/boot.S has the variables whose offset these macros are describing, I think it's fine to keep them. I'd rather not keep the macros that are not used outside boot.S. They give a wrong impression that somebody somewhere needs to know that offse

Re: [PATCH] unused constants in i386/boot.h

2009-07-12 Thread Yves Blusseau
On Thu, Jul 09, 2009 at 10:45:43AM +0200, Yves Blusseau wrote: style="font-family: -moz-fixed; font-size: 13px;" lang="x- western">Here's the patch to remove unused constants. The real constants used are GRUB_BOOT_MACHINE_KERNEL_ADDR and GRUB_BOOT_MACHINE_KERNEL_SEG. Hi, As long as boot

Re: [PATCH] unused constants in i386/boot.h

2009-07-10 Thread Robert Millan
On Thu, Jul 09, 2009 at 10:45:43AM +0200, Yves Blusseau wrote: > > > > > > style="font-family: -moz-fixed; font-size: 13px;" lang="x-western">Here's > the patch to remove unused constants. > The real constants used are GRUB_BOOT_MACHINE_KERNEL_ADDR and > GRUB_BOOT_MACHINE_KERNEL_SEG. Hi, A

[PATCH] unused constants in i386/boot.h

2009-07-09 Thread Yves Blusseau
Here's the patch to remove unused constants. The real constants used are GRUB_BOOT_MACHINE_KERNEL_ADDR and GRUB_BOOT_MACHINE_KERNEL_SEG. Best Regards, Yves Blusseau diff --git a/ChangeLog b/ChangeLog index 3fe273f..f8b098a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2009-07-09