Re: [PATCH] tests: Refactor building xorriso command for iso9660 tests

2021-12-10 Thread Glenn Washburn
On Wed, 08 Dec 2021 09:11:07 +0100 "Thomas Schmitt" wrote: > Hi, > > i think this change is beneficial for the maintainability of the test. > > But this sequence looks a bit confusing, albeit it is ok on the second > glimpse: > > + XORRISO_ARGS="-as mkisofs $XORRISOFS_CHARSET

Re: [PATCH] tests: Refactor building xorriso command for iso9660 tests

2021-12-08 Thread Thomas Schmitt
Hi, i think this change is beneficial for the maintainability of the test. But this sequence looks a bit confusing, albeit it is ok on the second glimpse: + XORRISO_ARGS="-as mkisofs $XORRISOFS_CHARSET -graft-points" + + if [ -z "${fs##*rockridge*}" ]; then +

[PATCH] tests: Refactor building xorriso command for iso9660 tests

2021-12-07 Thread Glenn Washburn
The iso9660 tests test creating isos with different combinations of joliet, rockridge, and iso9660 conformance level. Refactor xorriso argument generation for more readability and extensibility. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 43 +