Re: [PATCH] split realmode and loader routines out of startup.S

2008-01-04 Thread Robert Millan
On Fri, Jan 04, 2008 at 06:15:17PM +0100, Jeroen Dekkers wrote: > At Tue, 16 Oct 2007 23:09:07 +0200, > Robert Millan wrote: > > This patch splits realmode and loader routines out of startup.S. The idea > > is that the LinuxBIOS port can be adapted to share more code with the rest > > of GRUB inst

Re: [PATCH] split realmode and loader routines out of startup.S

2008-01-04 Thread Jeroen Dekkers
At Tue, 16 Oct 2007 23:09:07 +0200, Robert Millan wrote: > This patch splits realmode and loader routines out of startup.S. The idea > is that the LinuxBIOS port can be adapted to share more code with the rest > of GRUB instead of duplicating it. > > This is quite critical stuff, so even if the c

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-18 Thread Robert Millan
Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote: >> > >> > Linking required wrapping a lot of references with EXT_C() macro, so I >> > opted >> > for #include (note this is done for lzo1x.S already). >> >> Is using EXT_C a problem? I don

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Robert Millan
On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote: > > > > Linking required wrapping a lot of references with EXT_C() macro, so I opted > > for #include (note this is done for lzo1x.S already). > > Is using EXT_C a problem? I don't know this code too well, > unfortunately :( No. May

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote: >> >* kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ... >> >* kern/i386/loader.S (grub_linux_prot_size): ... here. >> >> I would say: >> >> (...): Moved from here... >> (.

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Robert Millan
On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote: > > * kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ... > > * kern/i386/loader.S (grub_linux_prot_size): ... here. > > I would say: > > (...): Moved from here... > (...): ... to here. > > Can you change that? Ok (A

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > This patch splits realmode and loader routines out of startup.S. The idea > is that the LinuxBIOS port can be adapted to share more code with the rest > of GRUB instead of duplicating it. > > This is quite critical stuff, so even if the change seems tri

[PATCH] split realmode and loader routines out of startup.S

2007-10-16 Thread Robert Millan
This patch splits realmode and loader routines out of startup.S. The idea is that the LinuxBIOS port can be adapted to share more code with the rest of GRUB instead of duplicating it. This is quite critical stuff, so even if the change seems trivial I'd suggest being careful, since I don't trust