Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards: >> Felix Zielcke <[EMAIL PROTECTED]> writes: >> >> > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> >> > >> >* partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid >> >

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Felix Zielcke
Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards: > Felix Zielcke <[EMAIL PROTECTED]> writes: > > > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> > > > > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid > > BSD > > magic or if there's no space left, use

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Felix Zielcke
Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards: > Felix Zielcke <[EMAIL PROTECTED]> writes: > > > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> > > > > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid > > BSD > > magic or if there's no space left, use

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> > > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid > BSD > magic or if there's no space left, use grub_dprintf to issue a warning. Looks fine. > + { > +

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Felix Zielcke
Am Dienstag, den 05.08.2008, 12:49 +0200 schrieb Felix Zielcke: > Am Dienstag, den 05.08.2008, 12:16 +0200 schrieb Marco Gerards: > > Robert Millan <[EMAIL PROTECTED]> writes: > > > > > > > How about using grub_dprintf instead? > > > > Agreed. > > > > Attached. I forgot 2 little spaces ;) > I

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Felix Zielcke
Am Dienstag, den 05.08.2008, 12:16 +0200 schrieb Marco Gerards: > Robert Millan <[EMAIL PROTECTED]> writes: > > > > How about using grub_dprintf instead? > > Agreed. > Attached. I hope I get soon used to your changelog :) 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> * partmap/pc.c

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote: >> > - return grub_error (GRUB_ERR_BAD_PART_TABLE, >> > - "no space for disk label"); >> > - >> > + { >> > +grub_erro

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote: > > - return grub_error (GRUB_ERR_BAD_PART_TABLE, > > - "no space for disk label"); > > - > > + { > > + grub_error (GRUB_ERR_BAD_PART_TABLE, > > +

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Felix Zielcke
Am Freitag, den 01.08.2008, 12:40 +0200 schrieb Marco Gerards: > When does this occur? > That's the Debian bugreport for it: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=478238 It's very easy to reproduce. I never used any *BSD flavour just Linux so I even didn't know about these BSD subpar

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > On invalid BSD partitions partmap/pc.c stops with reading the partitons, > so grub doestn't know anything about the ones behind it. > Attached patch fixes this and displays also the partition number not > only the invalid magic it encounters > > 2008-07-

[PATCH] skip over invalid BSD partitions

2008-07-30 Thread Felix Zielcke
On invalid BSD partitions partmap/pc.c stops with reading the partitons, so grub doestn't know anything about the ones behind it. Attached patch fixes this and displays also the partition number not only the invalid magic it encounters 2008-07-31 Felix Zielcke <[EMAIL PROTECTED]> * part