Re: [PATCH] r1986 broke FAT detection

2009-02-22 Thread Javier Martín
El sáb, 21-02-2009 a las 14:13 +0100, Robert Millan escribió: > On Tue, Feb 10, 2009 at 12:44:14PM +0100, Javier Martín wrote: > > > > > You're welcome. I see that nevertheless the "0 != " comparisons were > > substituted for standard C int-to-bool-conversion-based comparisons. > > Maybe people sh

Re: [PATCH] r1986 broke FAT detection

2009-02-21 Thread Robert Millan
On Tue, Feb 10, 2009 at 12:44:14PM +0100, Javier Martín wrote: > > > You're welcome. I see that nevertheless the "0 != " comparisons were > substituted for standard C int-to-bool-conversion-based comparisons. > Maybe people should know the signature _and_ semantic contract of > strncmp, but freque

Re: [PATCH] r1986 broke FAT detection

2009-02-10 Thread Javier Martín
El mar, 10-02-2009 a las 10:50 +0100, Felix Zielcke escribió: > Am Dienstag, den 10.02.2009, 01:19 +0100 schrieb Javier Martín: > > At r1985, "sudo ./grub-probe -t fs -d /dev/fd0" outputs "fat" with a > > freshly-formatted VFAT floppy in the drive. At r1986, it spits "error: > > unknown filesystem"

Re: [PATCH] r1986 broke FAT detection

2009-02-10 Thread Felix Zielcke
Am Dienstag, den 10.02.2009, 01:19 +0100 schrieb Javier Martín: > At r1985, "sudo ./grub-probe -t fs -d /dev/fd0" outputs "fat" with a > freshly-formatted VFAT floppy in the drive. At r1986, it spits "error: > unknown filesystem". The cause is this error, repeated three times: > > if (! grub_strnc

[PATCH] r1986 broke FAT detection

2009-02-09 Thread Javier Martín
At r1985, "sudo ./grub-probe -t fs -d /dev/fd0" outputs "fat" with a freshly-formatted VFAT floppy in the drive. At r1986, it spits "error: unknown filesystem". The cause is this error, repeated three times: if (! grub_strncmp(something, "FAT12", 5)) goto fail; Strncmp does not return a boolean